Root cause (src/core/store/appStore.ts): persistState() tried to figure out which data was "real" vs. demo by re-reading useAppStore.getState() — but that's the exact same in-memory store that had just been overwritten with MOCK_DEEDS/fake demo logs when demo mode turned on. The check was circular, not an actual fallback to disk. So any store action while demo mode was active (logging a prayer, adding a deed, etc.) wrote the fake demo data straight to disk, permanently overwriting the user's real save file. Turning demo mode back off then reloaded from disk — which now only held demo data — so the user's real deeds/logs were gone for good.

Fix: added a realDeeds/realLogs slice to the store that holds the user's actual data and is never touched while demo mode is on. All mutating actions route through a small helper that updates the displayed deeds/logs always, but only syncs realDeeds/realLogs when demo mode is off. persistState() now always writes from realDeeds/realLogs, so demo data can never reach disk.

Verified npm run checks:tsc and npm run checks:lint pass (only pre-existing, unrelated formatting warnings).

Pushed to branch claude/fix-demo-mode-data-loss and opened PR: #22

## Fixed: demo mode was silently overwriting real user data **Root cause** (`src/core/store/appStore.ts`): `persistState()` tried to figure out which data was "real" vs. demo by re-reading `useAppStore.getState()` — but that's the exact same in-memory store that had just been overwritten with `MOCK_DEEDS`/fake demo logs when demo mode turned on. The check was circular, not an actual fallback to disk. So any store action while demo mode was active (logging a prayer, adding a deed, etc.) wrote the fake demo data straight to disk, permanently overwriting the user's real save file. Turning demo mode back off then reloaded from disk — which now only held demo data — so the user's real deeds/logs were gone for good. **Fix**: added a `realDeeds`/`realLogs` slice to the store that holds the user's actual data and is never touched while demo mode is on. All mutating actions route through a small helper that updates the displayed `deeds`/`logs` always, but only syncs `realDeeds`/`realLogs` when demo mode is off. `persistState()` now always writes from `realDeeds`/`realLogs`, so demo data can never reach disk. Verified `npm run checks:tsc` and `npm run checks:lint` pass (only pre-existing, unrelated formatting warnings). Pushed to branch `claude/fix-demo-mode-data-loss` and opened PR: **https://code.uwayss.com/uwayss/muhsin/pulls/22**

claude-bot referenced this issue from a pull request that will close it,

2026-08-30 20:25:52 +00:00

fix: prevent demo mode from overwriting real user data #22

uwayss closed this issue

2026-08-30 23:15:20 +00:00