some claims in PRIVACY.md are wrong #20
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
We say that the app never touches the network but:
SettingsScreen.tsxthe privacy policy link in the settings links to here like:We should:
@claude open a PR resolving all of these pls and i'll take a look
I pushed a branch
claude/privacy-ota-fixes(commit2361367) addressing all three points:1. Opt-out for automatic OTA checks
app.json: setupdates.checkAutomaticallyto"ON_ERROR_RECOVERY", so expo-updates no longer auto-checks on every cold launch on its own.src/core/services/updateService.tswithcheckForOtaUpdate(), which does the check/fetch/reload manually.isAutoUpdateEnabledsetting (defaulttrue, preserving current behavior) wired intoappStore.ts, called frominitialize()only when enabled.settingsData.ts,SettingsListItem.tsx), translated into all six locales.2. Updated
PRIVACY.mdota.uwayss.comon every cold launch by default (sending IP, app version, platform) for bug fixes/small improvements, and that it can be turned off in Settings. Removed the "never touches the network" claim.3. Privacy policy now renders in-app
src/screens/PrivacyPolicyScreen.tsx, registered in the Settings stack navigator.privacyPolicy.*inen.json, mirroring thePRIVACY.mdrewrite) — no network request needed. Since it ships with the JS bundle, an OTA update will carry future edits to whatever version users are on, per your point #3.Verified with
tsc --noEmit,expo lint, andprettier --check— all clean (the 4 pre-existing prettier warnings insrc/constants/*.tsare unrelated to this change).Compare/PR link: https://code.uwayss.com/uwayss/muhsin/compare/main...claude/privacy-ota-fixes
One thing worth a second look before merging: I left the legal-text body of the new in-app privacy screen in English only (falling back via
i18n.enableFallback) rather than machine-translating it into the other five locales, since inaccurate translations of policy text seemed riskier than an English fallback. Happy to add translations if you'd prefer.