uwayss/muhsin
1
0
Fork 0
Code Issues 6 Pull requests Projects Releases Packages Wiki Activity Actions

fix: respect Android navigation bar safe area for tab bar #28

Merged
uwayss merged 2 commits from claude/fix-tab-bar-nav-bar-27 into develop 2026-08-31 08:37:31 +00:00
Conversation 0 Commits 2 Files changed 4 +17 -21
uwayss commented 2026-08-31 07:05:05 +00:00
Owner
Copy link

App.tsx never wrapped the tree in SafeAreaProvider, so
useSafeAreaInsets() everywhere returned zero and the bottom tab bar
rendered underneath the Android system navigation bar instead of
above it.

Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com

App.tsx never wrapped the tree in SafeAreaProvider, so useSafeAreaInsets() everywhere returned zero and the bottom tab bar rendered underneath the Android system navigation bar instead of above it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
fix: respect Android navigation bar safe area for tab bar
All checks were successful
Checks / checks (pull_request) Successful in 21s
Details
e5ce5bf004 
App.tsx never wrapped the tree in SafeAreaProvider, so
useSafeAreaInsets() everywhere returned zero and the bottom tab bar
rendered underneath the Android system navigation bar instead of
above it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
refactor(nav): read safe area insets at point of use
All checks were successful
Checks / checks (pull_request) Successful in 24s
Details
f67be1dcb5 
Header now calls useSafeAreaInsets() itself instead of taking an
insets prop threaded through Screen, so Screen no longer has to know
about safe areas at all. Drops the stale Omit<HeaderProps, 'insets'>
that TypeScript was silently accepting.

Also clip the Android tab bar ripple to the item bounds via
tabBarItemStyle, since react-navigation renders it borderless by
default.
uwayss force-pushed claude/fix-tab-bar-nav-bar-27 from f67be1dcb5
All checks were successful
Checks / checks (pull_request) Successful in 24s
Details
to 4dd13777b6
Some checks failed
Checks / checks (pull_request) Has been cancelled
Details
2026-08-31 08:36:28 +00:00 Compare
uwayss force-pushed claude/fix-tab-bar-nav-bar-27 from 4dd13777b6
Some checks failed
Checks / checks (pull_request) Has been cancelled
Details
to 39bf35462e
All checks were successful
Checks / checks (pull_request) Successful in 26s
Details
2026-08-31 08:36:44 +00:00 Compare
uwayss merged commit 5fb5dec5e1 into develop 2026-08-31 08:37:31 +00:00
uwayss deleted branch claude/fix-tab-bar-nav-bar-27 2026-08-31 08:37:32 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
code
About code quality or conventions

  
docs
It's about documentation

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
question
More information is needed

  
styles
UI related

  
wontfix
This won't be fixed

No labels
bug
code
docs
duplicate
enhancement
help wanted
invalid
question
styles
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
uwayss/muhsin!28
No description provided.