Fresh installs ship with fake prayer logs #19

New issue

Closed

opened 2026-08-30 20:12:56 +00:00 by uwayss · 2 comments

uwayss commented

2026-08-30 20:12:56 +00:00

Owner

in appStore.ts and data/mock.ts

The Stats screen and activity graph show five hardcoded logs dated 2025-08-28/2025-08-29 in first launch. Should be [].

in appStore.ts and data/mock.ts The Stats screen and activity graph show five hardcoded logs dated 2025-08-28/2025-08-29 in first launch. Should be [].

uwayss commented

2026-08-30 20:13:10 +00:00

Author

Owner

@claude i found this in the code but can you verify it pls i might be wrong

claude-bot commented

2026-08-30 20:13:18 +00:00

Collaborator

Pushed. Here's the reply for the issue:

Confirmed — you found it

The bug is in initialize() in src/core/store/appStore.ts:

let initialLogs = MOCK_LOGS;   // default, used before checking loadedData

if (loadedData) {
  ...
  initialLogs = loadedData.logs;
}

On a fresh install there's no loadedData, so initialLogs stays at MOCK_LOGS — the five hardcoded logs dated 2025-08-28/2025-08-29 from src/core/data/mock.ts. That's why the Stats screen and activity graph show fake activity on first launch instead of an empty state.

(MOCK_DEEDS, the actual list of prayer definitions like Fajr/Dhuhr/etc., is fine to default to — that's real app data, not fake demo history.)

Fix

Pushed to branch claude/fix-fresh-install-fake-logs-19:

Default initialLogs to [] instead of MOCK_LOGS.
Removed MOCK_LOGS (now unused) from mock.ts.

Verified tsc --noEmit and expo lint both pass clean (only pre-existing, unrelated warnings remain in other files).

Pushed. Here's the reply for the issue: ## Confirmed — you found it The bug is in `initialize()` in `src/core/store/appStore.ts`: ```ts let initialLogs = MOCK_LOGS; // default, used before checking loadedData if (loadedData) { ... initialLogs = loadedData.logs; } ``` On a fresh install there's no `loadedData`, so `initialLogs` stays at `MOCK_LOGS` — the five hardcoded logs dated `2025-08-28`/`2025-08-29` from `src/core/data/mock.ts`. That's why the Stats screen and activity graph show fake activity on first launch instead of an empty state. (`MOCK_DEEDS`, the actual list of prayer definitions like Fajr/Dhuhr/etc., is fine to default to — that's real app data, not fake demo history.) ## Fix Pushed to branch `claude/fix-fresh-install-fake-logs-19`: - Default `initialLogs` to `[]` instead of `MOCK_LOGS`. - Removed `MOCK_LOGS` (now unused) from `mock.ts`. Verified `tsc --noEmit` and `expo lint` both pass clean (only pre-existing, unrelated warnings remain in other files).

claude-bot referenced this issue from a commit

2026-08-30 20:15:00 +00:00

fix: don't seed fresh installs with fake prayer logs

uwayss referenced this issue from a pull request that will close it,

2026-08-30 20:19:37 +00:00

fix: don't seed fresh installs with fake prayer logs #21

uwayss closed this issue

2026-08-30 20:20:59 +00:00

uwayss referenced this issue from a commit

2026-08-30 20:20:59 +00:00

fix: don't seed fresh installs with fake prayer logs (#21)