fix(privacy): honor no-network claims, add OTA opt-out, bundle privacy policy #23

Merged

uwayss merged 5 commits from claude/privacy-ota-fixes into main 2026-08-30 23:47:55 +00:00

Conversation 4 Commits 5 Files changed 12 +119 -17

uwayss commented 2026-08-30 20:30:19 +00:00

Owner

Copy link

• Disable expo-updates' automatic ON_LOAD check and gate the OTA check
  behind a new "Automatic Updates" setting (on by default), so users can
  opt out of the per-cold-launch request to ota.uwayss.com.
• Update PRIVACY.md to accurately describe the OTA update check.
• Add an in-app Privacy Policy screen (bundled, no network needed) and
  point the settings link at it instead of an external URL.

Closes #20

- Disable expo-updates' automatic ON_LOAD check and gate the OTA check behind a new "Automatic Updates" setting (on by default), so users can opt out of the per-cold-launch request to ota.uwayss.com. - Update PRIVACY.md to accurately describe the OTA update check. - Add an in-app Privacy Policy screen (bundled, no network needed) and point the settings link at it instead of an external URL. Closes #20

uwayss added 1 commit 2026-08-30 20:30:19 +00:00

fix(privacy): honor no-network claims, add OTA opt-out, bundle privacy policy ... 23613677ce

- Disable expo-updates' automatic ON_LOAD check and gate the OTA check
  behind a new "Automatic Updates" setting (on by default), so users can
  opt out of the per-cold-launch request to ota.uwayss.com.
- Update PRIVACY.md to accurately describe the OTA update check.
- Add an in-app Privacy Policy screen (bundled, no network needed) and
  point the settings link at it instead of an external URL.

Closes #20

uwayss commented 2026-08-30 20:34:44 +00:00

Author

Owner

Copy link

@claude give me a full list of all the behavioral changes in this PR. every file and every change. i want a table. explain clearly. be clear, direct and concise

@claude give me a full list of all the behavioral changes in this PR. every file and every change. i want a table. explain clearly. be clear, direct and concise

claude-bot commented 2026-08-30 20:34:51 +00:00

Collaborator

Copy link

I have the full diff. No file changes needed — this is a pure explanation request. Here's my reply.

Behavioral changes in this PR

File	Change	User-visible effect
app.json	Added "checkAutomatically": "ON_ERROR_RECOVERY" to the updates block.	Expo no longer auto-checks for an OTA update on every cold launch (ON_LOAD, the previous default). It now only checks automatically as an error-recovery fallback; the normal update check moves entirely into app code (see below).
src/core/services/updateService.ts (new)	Adds checkForOtaUpdate(): calls Updates.checkForUpdateAsync(), and if an update is available, fetches and applies it via reloadAsync(). No-ops if Updates.isEnabled is false; errors are caught and logged, not thrown.	This is now the only code path that hits ota.uwayss.com, and it's called conditionally (see appStore.ts), not automatically by the Updates runtime.
src/core/store/appStore.ts	• New setting isAutoUpdateEnabled: boolean, default true. • New action toggleAutoUpdate(). • On store init, calls checkForOtaUpdate() only if (settings.isAutoUpdateEnabled).	The OTA network request on cold start now happens only when the user hasn't disabled the new setting. Existing users get it on by default (no behavior change unless they opt out); new toggle persists via existing persistState.
src/features/settings/settingsData.ts	• New toggle item "Automatic Updates" (isAutoUpdateEnabled) added to the settings list, under Haptics. • "Privacy Policy" item type changed from action (opened external URL) to navigation (path: 'PrivacyPolicy').	Adds a visible toggle in Settings. Tapping "Privacy Policy" now opens an in-app screen instead of leaving the app.
src/features/settings/SettingsListItem.tsx	• handleToggle now also handles isAutoUpdateEnabled, calling toggleAutoUpdate(). • Haptic feedback (triggerHaptic()) now fires for any toggle, not just haptics. • Removed the special-case that hid the chevron on the old Privacy action item (no longer needed since it's a navigation item).	New toggle is functional and gives haptic feedback like the others. Privacy row now shows a chevron like other navigation rows.
src/screens/SettingsScreen.tsx	Removed the privacy: () => Linking.openURL(...) action (dead code — no longer referenced since the settings item type changed).	No visible change beyond the navigation change above; Linking is still used for other actions (rate app, feedback email) so no import is left dangling.
src/navigation/AppNavigator.tsx	Registers new PrivacyPolicyScreen in the Settings stack (PrivacyPolicy route).	Enables in-app navigation to the new screen.
src/screens/PrivacyPolicyScreen.tsx (new)	New screen rendering a bundled, translated privacy policy (intro, 5 items, footer) — no network calls, no external links.	Users get privacy policy content entirely offline/in-app instead of being sent to an external CodeHub URL.
src/core/i18n/en.json	Adds screens.privacyPolicy, settings.autoUpdates, and a full privacyPolicy block (intro, 5 items, footer).	Provides the strings for the new toggle label and the new screen.
src/core/i18n/ar.json, de.json, es.json, fa.json, tr.json	Same two new keys added (screens.privacyPolicy, settings.autoUpdates) — only these two, not the full privacyPolicy block.	Non-English locales get a translated toggle label and screen title, but the Privacy Policy screen body text (privacyPolicy.items, intro, footer) will fall back to English for these languages, since only en.json has that block. Worth flagging as a possible follow-up if full localization is expected.
PRIVACY.md	Rewrites the "Short Version" and "Details" sections: removes the "no internet access" / "works completely offline" claims, replaces them with an accurate description of the OTA check (what data it sends, that it's on ota.uwayss.com, and that it can be disabled in Settings). Renumbers items 4→5 to insert the new "Automatic Updates" item.	Documentation-only; brings the privacy policy in line with actual app behavior instead of the previous (inaccurate) "no network access" claim.

Net behavioral summary

1. OTA checks are no longer silently automatic — Expo's built-in ON_LOAD auto-check is disabled; the check is now explicit app code gated by a setting.
2. New "Automatic Updates" setting, on by default, lets users opt out of the update check entirely.
3. Privacy Policy is now in-app and offline, not an external link to CodeHub.
4. Documentation now matches reality: previously PRIVACY.md claimed no network access at all, which wasn't true given the OTA check; it's now accurate and discloses exactly what the update request sends.

I have the full diff. No file changes needed — this is a pure explanation request. Here's my reply. ## Behavioral changes in this PR | File | Change | User-visible effect | |---|---|---| | `app.json` | Added `"checkAutomatically": "ON_ERROR_RECOVERY"` to the `updates` block. | Expo no longer auto-checks for an OTA update on every cold launch (`ON_LOAD`, the previous default). It now only checks automatically as an error-recovery fallback; the normal update check moves entirely into app code (see below). | | `src/core/services/updateService.ts` **(new)** | Adds `checkForOtaUpdate()`: calls `Updates.checkForUpdateAsync()`, and if an update is available, fetches and applies it via `reloadAsync()`. No-ops if `Updates.isEnabled` is false; errors are caught and logged, not thrown. | This is now the *only* code path that hits `ota.uwayss.com`, and it's called conditionally (see `appStore.ts`), not automatically by the Updates runtime. | | `src/core/store/appStore.ts` | • New setting `isAutoUpdateEnabled: boolean`, default `true`.<br>• New action `toggleAutoUpdate()`.<br>• On store init, calls `checkForOtaUpdate()` only `if (settings.isAutoUpdateEnabled)`. | The OTA network request on cold start now happens only when the user hasn't disabled the new setting. Existing users get it on by default (no behavior change unless they opt out); new toggle persists via existing `persistState`. | | `src/features/settings/settingsData.ts` | • New toggle item "Automatic Updates" (`isAutoUpdateEnabled`) added to the settings list, under Haptics.<br>• "Privacy Policy" item type changed from `action` (opened external URL) to `navigation` (`path: 'PrivacyPolicy'`). | Adds a visible toggle in Settings. Tapping "Privacy Policy" now opens an in-app screen instead of leaving the app. | | `src/features/settings/SettingsListItem.tsx` | • `handleToggle` now also handles `isAutoUpdateEnabled`, calling `toggleAutoUpdate()`.<br>• Haptic feedback (`triggerHaptic()`) now fires for *any* toggle, not just haptics.<br>• Removed the special-case that hid the chevron on the old Privacy `action` item (no longer needed since it's a `navigation` item). | New toggle is functional and gives haptic feedback like the others. Privacy row now shows a chevron like other navigation rows. | | `src/screens/SettingsScreen.tsx` | Removed the `privacy: () => Linking.openURL(...)` action (dead code — no longer referenced since the settings item type changed). | No visible change beyond the navigation change above; `Linking` is still used for other actions (rate app, feedback email) so no import is left dangling. | | `src/navigation/AppNavigator.tsx` | Registers new `PrivacyPolicyScreen` in the Settings stack (`PrivacyPolicy` route). | Enables in-app navigation to the new screen. | | `src/screens/PrivacyPolicyScreen.tsx` **(new)** | New screen rendering a bundled, translated privacy policy (intro, 5 items, footer) — no network calls, no external links. | Users get privacy policy content entirely offline/in-app instead of being sent to an external CodeHub URL. | | `src/core/i18n/en.json` | Adds `screens.privacyPolicy`, `settings.autoUpdates`, and a full `privacyPolicy` block (`intro`, 5 `items`, `footer`). | Provides the strings for the new toggle label and the new screen. | | `src/core/i18n/ar.json`, `de.json`, `es.json`, `fa.json`, `tr.json` | Same two new keys added (`screens.privacyPolicy`, `settings.autoUpdates`) — **only** these two, not the full `privacyPolicy` block. | Non-English locales get a translated toggle label and screen title, but the Privacy Policy screen body text (`privacyPolicy.items`, `intro`, `footer`) will fall back to English for these languages, since only `en.json` has that block. Worth flagging as a possible follow-up if full localization is expected. | | `PRIVACY.md` | Rewrites the "Short Version" and "Details" sections: removes the "no internet access" / "works completely offline" claims, replaces them with an accurate description of the OTA check (what data it sends, that it's on `ota.uwayss.com`, and that it can be disabled in Settings). Renumbers items 4→5 to insert the new "Automatic Updates" item. | Documentation-only; brings the privacy policy in line with actual app behavior instead of the previous (inaccurate) "no network access" claim. | ### Net behavioral summary 1. **OTA checks are no longer silently automatic** — Expo's built-in `ON_LOAD` auto-check is disabled; the check is now explicit app code gated by a setting. 2. **New "Automatic Updates" setting**, on by default, lets users opt out of the update check entirely. 3. **Privacy Policy is now in-app and offline**, not an external link to CodeHub. 4. **Documentation now matches reality**: previously PRIVACY.md claimed no network access at all, which wasn't true given the OTA check; it's now accurate and discloses exactly what the update request sends.

uwayss commented 2026-08-30 23:24:20 +00:00

Author

Owner

Copy link

@claude 1- Actually no, we don't need to give users the option to opt out of automatic updates because adding that option ruins the updates for normal users. Because now we don't use Expo's default behavior and we have to restart the app ourselves to apply updates which is definitely a worse experience than just applying the next bundle in the next launch. We're just acknowledging the fact that ota updates exist. We're not adding options for them
2- we gotta translate the privacy policy to the other languages as well. not just in the app but also the markdown file in the repo.

@claude 1- Actually no, we don't need to give users the option to opt out of automatic updates because adding that option ruins the updates for normal users. Because now we don't use Expo's default behavior and we have to restart the app ourselves to apply updates which is definitely a worse experience than just applying the next bundle in the next launch. We're just acknowledging the fact that ota updates exist. We're not adding options for them 2- we gotta translate the privacy policy to the other languages as well. not just in the app but also the markdown file in the repo.

claude-bot commented 2026-08-30 23:24:27 +00:00

Collaborator

Copy link

Both requested changes are now on branch claude/privacy-ota-fixes (PR #23), pushed as commit a686dd6.

What changed

1. Removed the auto-update opt-out (per your feedback that it makes updates worse for normal users):

• app.json: dropped checkAutomatically: "ON_ERROR_RECOVERY" — Expo is back to its default ON_LOAD behavior, applying the next bundle automatically on a future cold start.
• Deleted src/core/services/updateService.ts entirely (no more explicit checkForUpdateAsync/fetchUpdateAsync/reloadAsync calls or the immediate-reload-on-cold-start behavior).
• appStore.ts: removed isAutoUpdateEnabled, toggleAutoUpdate, and the gated check from initialize().
• settingsData.ts / SettingsListItem.tsx: removed the "Automatic Updates" toggle row and its handling entirely — settings no longer mention OTA updates at all, they just happen silently via Expo's default mechanism.
• PRIVACY.md / en.json's privacyPolicy block: updated wording to just acknowledge the OTA check exists, with no mention of an opt-out.

2. Translated the privacy policy into Arabic, German, Spanish, Persian, and Turkish:

• Added the full privacyPolicy block (intro, 5 items, matching content) to each locale's JSON file, so the in-app Privacy Policy screen is fully localized instead of falling back to English.
• Added PRIVACY.ar.md, PRIVACY.de.md, PRIVACY.es.md, PRIVACY.fa.md, PRIVACY.tr.md in the repo root, with a language-switcher line added to the top of each (including the English PRIVACY.md).

Note: while pushing, I found uwayss had pushed a commit directly to this branch in the meantime (dropping the privacy-policy footer line, adding a dev-mode guard to the old update check). I rebased on top of it — the dev-mode guard is moot since that file is now deleted, and I removed the footer key from my new translations to stay consistent with that change.

Verified tsc --noEmit, expo lint, and prettier --check all pass (only pre-existing unrelated warnings remain).

Both requested changes are now on branch `claude/privacy-ota-fixes` (PR #23), pushed as commit `a686dd6`. ## What changed **1. Removed the auto-update opt-out** (per your feedback that it makes updates worse for normal users): - `app.json`: dropped `checkAutomatically: "ON_ERROR_RECOVERY"` — Expo is back to its default `ON_LOAD` behavior, applying the next bundle automatically on a future cold start. - Deleted `src/core/services/updateService.ts` entirely (no more explicit `checkForUpdateAsync`/`fetchUpdateAsync`/`reloadAsync` calls or the immediate-reload-on-cold-start behavior). - `appStore.ts`: removed `isAutoUpdateEnabled`, `toggleAutoUpdate`, and the gated check from `initialize()`. - `settingsData.ts` / `SettingsListItem.tsx`: removed the "Automatic Updates" toggle row and its handling entirely — settings no longer mention OTA updates at all, they just happen silently via Expo's default mechanism. - `PRIVACY.md` / `en.json`'s `privacyPolicy` block: updated wording to just acknowledge the OTA check exists, with no mention of an opt-out. **2. Translated the privacy policy** into Arabic, German, Spanish, Persian, and Turkish: - Added the full `privacyPolicy` block (intro, 5 items, matching content) to each locale's JSON file, so the in-app Privacy Policy screen is fully localized instead of falling back to English. - Added `PRIVACY.ar.md`, `PRIVACY.de.md`, `PRIVACY.es.md`, `PRIVACY.fa.md`, `PRIVACY.tr.md` in the repo root, with a language-switcher line added to the top of each (including the English `PRIVACY.md`). Note: while pushing, I found `uwayss` had pushed a commit directly to this branch in the meantime (dropping the privacy-policy footer line, adding a dev-mode guard to the old update check). I rebased on top of it — the dev-mode guard is moot since that file is now deleted, and I removed the `footer` key from my new translations to stay consistent with that change. Verified `tsc --noEmit`, `expo lint`, and `prettier --check` all pass (only pre-existing unrelated warnings remain).

uwayss added 1 commit 2026-08-30 23:25:39 +00:00

fix: remove footer in privacy policy screen and don't check for updates ... d445b701a9

when in a dev session and

claude-bot added 1 commit 2026-08-30 23:31:46 +00:00

fix(privacy): drop OTA opt-out, translate privacy policy ... a686dd6c7e

- Revert to Expo's default automatic OTA update behavior (ON_LOAD
  check applies the next bundle on the following cold start) instead
  of gating updates behind an app-level "Automatic Updates" setting,
  which required manually reloading and made updates feel worse.
- Remove the now-unused updateService and its setting/toggle.
- Translate the in-app Privacy Policy screen and PRIVACY.md into
  Arabic, German, Spanish, Persian, and Turkish.

uwayss added 1 commit 2026-08-30 23:38:47 +00:00

fix: those translations are shit and they would cause more problems than ... 3c7aa4fe3a

clearifications. i undid all of them

uwayss force-pushed claude/privacy-ota-fixes from 3c7aa4fe3a to d7d169894e 2026-08-30 23:39:05 +00:00 Compare

uwayss force-pushed claude/privacy-ota-fixes from d7d169894e to 168bcc06d6 2026-08-30 23:45:54 +00:00 Compare

uwayss added 1 commit 2026-08-30 23:47:19 +00:00

fix(settings): drop unused privacy action from SettingsActions ... 9ae7a23a8c

The privacy row is a navigation item now, so no screen supplies a
privacy action and tsc failed on the missing property.

uwayss merged commit 373e405ded into main 2026-08-30 23:47:55 +00:00

uwayss deleted branch claude/privacy-ota-fixes 2026-08-30 23:47:56 +00:00

uwayss referenced this pull request from a commit 2026-08-30 23:47:56 +00:00

fix(privacy): honor no-network claims, add OTA opt-out, bundle privacy policy (#23)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

code

About code quality or conventions

  

docs

It's about documentation

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

question

More information is needed

  

styles

UI related

  

wontfix

This won't be fixed

No labels

bug

code

docs

duplicate

enhancement

help wanted

invalid

question

styles

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

2 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

uwayss/muhsin!23

No description provided.